Diorama-based app spec tests #1475
Conversation
maackle
changed the base branch from
develop
to
reset-conductor-api-after-adding-bridge
CHANGELOG-UNRELEASED.md
Outdated
| @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
| - Error log output added for errors occurring during `hdk::call`, including bridge call errors [#1448](https://github.com/holochain/holochain-rust/pull/1448). | |||
| - New `uuid` parameter for `admin/dna/install_from_file`, to set the UUID of the installed DNA, changing its hash | |||
| }; | ||
|
|
||
| /// how many milliseconds sleep all bugs under rugs |
There was a problem hiding this comment.
lol, but also.
Can I get an update/explainer? What's happening that we need to do this?
There was a problem hiding this comment.
This is a workaround for #1446
There was a problem hiding this comment.
Ok cool, well maybe we could put that into the code itself so that there's a good record
| fn main() { | ||
| if Path::new("../.git/HEAD").exists() { |
There was a problem hiding this comment.
Can we use pathbuf instead? Just handles the seperators better
There was a problem hiding this comment.
Isn't Path just a slice of a PathBuf?
There was a problem hiding this comment.
Pathbuf is to string as Path is to &str , so what we would want is to PathBuf::().join() so that we dont have to handle the seperator logic for different Oses
There was a problem hiding this comment.
@maackle @AshantiMutinta yes and this is my code and i hate it whoops
|
@maackle I notice the attempt to do They produce: in the CI. I'm assuming they would do the same locally. I need to double check to verify which |
…in-rust into diorama-app-spec-tests
This reverts commit 3b44e47.
Yeah, @thedavidmeister you think we can add |
…/holochain-rust into diorama-app-spec-tests
…in-rust into diorama-app-spec-tests
lucksus
changed the base branch from
reset-conductor-api-after-adding-bridge
to
develop
| mkdir -p dist | ||
| echo "====================================================================================" | ||
| echo "RUNNING cargo test for zomes" | ||
| echo "Using conductor binary: `which holochain`" | ||
| echo "Using cli binary: `which hc`" |
There was a problem hiding this comment.
One of the sources of whichiness @thedavidmeister
PR summary
Based on #1425 and https://github.com/holochain/holochain-rust/tree/reset-conductor-api-after-adding-bridge (PR forthcoming)
Uses diorama instead of nodejs_conductor to run app-spec tests. This is in preparation for removing nodejs_conductor from this repo and ceasing to use it for app-spec tests.
followups
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)